Closed cmyr closed 5 years ago
Merging #362 into master will decrease coverage by
0.03%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 44.11% 44.08% -0.04%
==========================================
Files 31 31
Lines 3883 3886 +3
==========================================
Hits 1713 1713
- Misses 2170 2173 +3
Impacted Files | Coverage Δ | |
---|---|---|
Sources/XiEditor/EditViewController.swift | 27.25% <0%> (-0.16%) |
:arrow_down: |
Sources/XiEditor/XiDocumentController.swift | 46.21% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c0d666a...91150a9. Read the comment docs.
Looks good :+1: I still need to take a look into the code in order to get the context of the changes. Will let you know tomorrow.
Ok, I compiled this and it solves my issue :+1: Let's close the ticket.
I took a wider look at the EditViewController
and there's a clear room for the refactor there.. Is this ok for you if I would create a follow-up PR with some decoupling of this component? :smile:
@mmatoszko That would be much appreciated!
cc @mmatoszko
Review Checklist