Single CLI Button - Githubissues

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Single CLI Button #405

Closed liamrosenfeld closed 5 years ago

liamrosenfeld commented 5 years ago

Summary

Unifies the two CLI Buttons into a single button that toggles between the two.

Checklist

[x] Toggles Name
[x] Toggles Functionality

Review Checklist

[x] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

liamrosenfeld commented 5 years ago

@mmatoszko, the install/remove enum's raw values could be set to a localization variable.

cmyr commented 5 years ago

@mmatoszko My gut feeling is that while we're still in the experimentation phase ignoring localization is okay; ultimately a lot will be changing between now and whenever we do a public release. Once we're at a stage where we're actually publishing an app package we'll want to go through and clean up all of our strings.

liamrosenfeld commented 5 years ago

Thanks!