Refactor enum in PluginCommand - Githubissues

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Refactor enum in PluginCommand #410

Closed s11y closed 5 years ago

s11y commented 5 years ago

Summary

This will make the project code swifty. I refactorRpcType and ArgumentType . The changes I made is below.

Add raw value to these cases.
Changing the first letter of the case name to a small letter from a capital letter.

Related Issues

nothing.

Checklist

[x] Build an application and tests.

Review Checklist

[x] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

s11y commented 5 years ago

I have just rebase this PR onto xi-mac/master. There is no change.

cmyr commented 5 years ago

Looks good, thanks!