Fix xi-mac command line being able to open folders

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Fix xi-mac command line being able to open folders #439

Closed nangtrongvuon closed 5 years ago

nangtrongvuon commented 5 years ago

Summary

Small fix to make xi-mac CLI not open folders.

Should close #424.

Review Checklist

[x] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

mmatoszko commented 5 years ago

It seems that the reason it crashes on CI is referencing xi-editor submodule commit which is not available yet. Do we need to update xi-editor in this PR?

nangtrongvuon commented 5 years ago

Oh, I think it's actually pointing to my quick open branch on xi-editor. I'll amend my commit with the proper master.

Does this fix the part where xi becomes unable to open anything?

Not really, but it prevents it from happening in the first place. 🤷‍♂️ When the sidebar/workspace stuff comes, this can go away and hook into opening the folder as the workspace root instead.

mmatoszko commented 5 years ago

:rocket: