It looks like the main issue in #351 was the use of NSAppearance.vibrantDark instead of .darkAqua. This is due to vibrantDark using color blending instead of the system colors. Source This was probably done because .darkAqua only appears in 10.14+. I guess the option here is keep having too dark buttons prior to 10.14 or just always use the unified_titlebar colors.
Related Issues
Related to #351
Checklist
Example:
[ ] Example check-list item
[x] Create a pull request template
[ ] make xi perfect
Review Checklist
[ ] I have responded to reviews and made changes where appropriate.
[ ] I have tested the code
[ ] I have updated comments / documentation related to the changes I made.
[ ] I have rebased my PR branch onto xi-mac/master.
Summary
It looks like the main issue in #351 was the use of
NSAppearance.vibrantDarkinstead of.darkAqua. This is due tovibrantDarkusing color blending instead of the system colors. Source This was probably done because.darkAquaonly appears in 10.14+. I guess the option here is keep having too dark buttons prior to 10.14 or just always use theunified_titlebarcolors.Related Issues
Related to #351Checklist
Example:
Review Checklist