Upgrade to Swift 4.2 - Githubissues

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Upgrade to Swift 4.2 #463

Closed jeremywiebe closed 5 years ago

jeremywiebe commented 5 years ago

Summary

This PR moves the codebase to Swift 4.2. It turns out to be a pretty small.

Related Issues

--None--

Related to #461

Checklist

Example:

[x] Entire codebase compiles without error (including unit tests)
[x] All unit tests pass
[x] Xi doesn't crash in basic smoke-test

Review Checklist

[ ] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

jeremywiebe commented 5 years ago

Agreed. I figured this allows us to start using Xcode 10.2. I'm going to work on the Swift 5 conversion next... :)