Change default find highlight color

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Change default find highlight color #470

Open cmyr opened 5 years ago

cmyr commented 5 years ago

Currently find highlights are red by default. We should default to NSColor.findHighlightColor or something? There may also be a color defined in the theme that we can use. (The motivation for not using the colors in the theme is that we support multiple 'find groups' with different colors, and want these to be distinct, but I think we should default to an appropriate color for the first group.

mohanio commented 4 years ago

@cmyr , @nangtrongvuon added a fix for this here https://github.com/xi-editor/xi-mac/pull/481

cmyr commented 4 years ago

cool, thanks!

edit: will need to think about this a bit, but will give it a proper look monday or tuesday.