On certain setups, scrollers were not appearing on scroll due to XiClipView's scroll(to: NSPoint) declaration overriding the Apple's scroller management code.
This commit fixes that by calling super.scroll(to: ) to access the scroller management, and calling setBoundsOrigin from EditViewController.
Note that this is a bit of a hacky fix - the real fix would probably involve figuring out how to make XiTextPlane responsively render on notched mouse scroll, perhaps implementing prepareContentInRect, though I'm not quite sure if it would do the job.
Related Issues
Closes #476
Review Checklist
[ ] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.
Summary
On certain setups, scrollers were not appearing on scroll due to
XiClipView'sscroll(to: NSPoint)declaration overriding the Apple's scroller management code. This commit fixes that by callingsuper.scroll(to: )to access the scroller management, and callingsetBoundsOriginfromEditViewController.Note that this is a bit of a hacky fix - the real fix would probably involve figuring out how to make
XiTextPlaneresponsively render on notched mouse scroll, perhaps implementingprepareContentInRect, though I'm not quite sure if it would do the job.Related Issues
Closes #476
Review Checklist