#470 Change default find highlight color - Githubissues

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

#470 Change default find highlight color #481

Open mohanio opened 4 years ago

mohanio commented 4 years ago

Summary

Issue: https://github.com/xi-editor/xi-mac/issues/470 Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor)

Fix:

Theme has new static variable representing default find highlight color
Other find highlight colors are generated from the hue of default find highlight color
Find highlight color specified by xi-editor on theme_changed event is ignored

Related Issues

closes #470

Checklist

Example:

[ ] Example check-list item
[x] Create a pull request template
[ ] make xi perfect

Review Checklist

[ ] I have responded to reviews and made changes where appropriate.
[ ] I have tested the code
[ ] I have updated comments / documentation related to the changes I made.
[ ] I have rebased my PR branch onto xi-mac/master.

mohanio commented 4 years ago

Thanks for this! Overall looks good. but you shouldn't have the issue link as the commit message. Instead, describe what you did, and then put the link in the commit message body instead.

Updated the commit subject and message.