mohanio commented 4 years ago

Summary

480 Drag events cause file to be opened

Issue:

Files dragged over XiEditor window and dropped elsewhere is opened by XiEditor.
This is becasue file open is triggered from draggingEnded(_:) which is invoked immeterial of drop location

Fix:

Use draggingEntered(_:) to return the dragging operation that XiEditor will perform when dropped
Trigger file open from performDragOperation(_:) delegate callback

Related Issues

closes #480

Checklist

Example:

[ ] Example check-list item
[x] Create a pull request template
[ ] make xi perfect

Review Checklist

[ ] I have responded to reviews and made changes where appropriate.
[ ] I have tested the code
[ ] I have updated comments / documentation related to the changes I made.
[ ] I have rebased my PR branch onto xi-mac/master.

mohanio commented 4 years ago

Thanks for this, looks good to me, though I'd like the issue number to be removed from the commit message and instead have the link to the issue in the commit message body.

Thanks for the opportunity, would like to involve and contribute more. Made necessary changes to commit message.

nangtrongvuon commented 4 years ago

Oh, no, not like that. The body is fine, but your commit message has to be a short description of what you did. You can read more on that here.

mohanio commented 4 years ago

Oh, no, not like that. The body is fine, but your commit message has to be a short description of what you did. You can read more on that here.

Please merge the PR if it looks good.

nangtrongvuon commented 4 years ago

All good, thanks for this!

xi-editor / xi-mac