Status Bar Improvements - Githubissues

xi-editor / xi-mac

The xi-editor mac frontend.

Apache License 2.0

3.02k stars 147 forks source link

Status Bar Improvements #485

Closed nangtrongvuon closed 4 years ago

nangtrongvuon commented 4 years ago

Summary

This improves the current status bar present in xi-mac by:

Adding it to the view hiearchy instead of on top, fixing #475.
Refactors some code of the status bar to be cleaner, since it's now an integral part of the view and does not need to be manually created anymore.

Review Checklist

[ ] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

mmatoszko commented 4 years ago

@nangtrongvuon The code looks good, but one of the integration tests is failing right now. SearchIntegrationTests.testSearchingGoldenBoysCaseSensitive() is failing, this might be correlated with updating the xi-editor dependency.