search

xiCO2k / laravel-vue-i18n

Allows to connect your `Laravel` Framework translation files with `Vue`.
MIT License
620 stars 51 forks source link

feat/fix: Allow to opt-out of replacing slashes in keys #116

Closed BR0kEN- closed 1 year ago

BR0kEN- commented 1 year ago

https://github.com/xiCO2k/laravel-vue-i18n/issues/115

BR0kEN- commented 1 year ago

@xiCO2k any idea how to fix that without introducing a BC?

BR0kEN- commented 1 year ago

Alright, the idea I have come up with to not bring a BC is to introduce the option that allows disabling the errorish (in some cases) behavior.

Covers my use case of the laravel-vue-i18n for 100% as I was never intent to use dot/slash notation.

xiCO2k commented 1 year ago

Thanks for the PR, will review it and let you know

BR0kEN- commented 1 year ago

@xiCO2k please let me know whether this is something that can be expected or should I forget about it.

xiCO2k commented 1 year ago

Hey @BR0kEN- I think this is probably not the option.

I think a better way would be to take a look on both json with the full string and with the other way, do you want to make a PR with that?

Thanks again, Francisco

BR0kEN- commented 1 year ago

Didn't get what you meant. What JSON?

xiCO2k commented 1 year ago

@BR0kEN- check the PR https://github.com/xiCO2k/laravel-vue-i18n/pull/118 if it looks good to you.