search

xiCO2k / laravel-vue-i18n

Allows to connect your `Laravel` Framework translation files with `Vue`.
MIT License
599 stars 49 forks source link

HTML lang attribute value should use a hyphen instead of an underscore #9

Closed ckyoung closed 2 years ago

ckyoung commented 2 years ago

When using a language that differ by territory like zh-TW the plugin seems to reset the HTML lang attribute to underscore version.

Screenshot: Screen Recording 2022-01-26 at 03 22 02 PM

<html lang="zh_TW">

Should really be:

<html lang="zh-TW">

Ref: https://tools.ietf.org/html/rfc5646#section-2.1

NaincyKumariKnoldus commented 2 years ago

Hey @ckyoung I have raised a PR for this. Please review that!