search

xia2 / screen19

Screening program for small-molecule single-crystal X-ray diffraction data
https://pypi.org/project/screen19/
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Remove stability_fft.py and related test and utils #27

Closed benjaminhwilliams closed 4 years ago

benjaminhwilliams commented 4 years ago

What does this tool even do?

I suspect it probably relates to past investigations of instability in the monochromator on beamline I19 of Diamond Light Source. It certainly has nothing to do with screen19 and no-one seems to use it.

Does it do that thing well?

It's not clear. It has at least one command line parameter that does nothing.

Does it still work?

It does now (I just fixed it in https://github.com/xia2/screen19/commit/ee5c4f3b600a60a2a8586b4767cdee303f21bb01). For a long time, it was simply broken and it seems no-one noticed.

Is it tested?

Sort of — there are unit tests of two utilities (one of which is not used anywhere).

Docs?

Code is documentation, right?

So?

Remove it.

Anthchirp commented 4 years ago

exactly what you said. This was used to determine the frequency of vibrations on I19(-1 I believe) during commissioning