search

xia2 / screen19

Screening program for small-molecule single-crystal X-ray diffraction data
https://pypi.org/project/screen19/
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Get Travis to do regression testing #28

Closed benjaminhwilliams closed 2 years ago

benjaminhwilliams commented 4 years ago

@anthchirp, I was going to do this, then noticed you had an old branch ready to go and hadn't merged it. Intentional?

Anthchirp commented 4 years ago

looking at the travis log the most likely scenario is that there was an issue with our builds not working at the time and then I forgot about it.

If the builds pass now this can be merged I believe.

benjaminhwilliams commented 4 years ago

Thanks, will do. I anticipate one test failure (see Jenkins), but I'm fixing that in a separate branch.

benjaminhwilliams commented 4 years ago

Hmm... build timeouts during testing. I'll try longer.

Anthchirp commented 4 years ago

Could be that this is waiting on eg. https://github.com/dials/data/issues/33

benjaminhwilliams commented 4 years ago

Ah, that would make sense. And I don't think the 10 min limit is configurable. The tests themselves should be quite quick, so I imagine you're right and we're just waiting for the data.

Anthchirp commented 2 years ago

We won't be doing Travis.