Pull Request Submission: Update ed25519-hd-key to ed25519-keygen
Issue Description
The npm package ed25519-hd-key currently cannot be run in the browser due to its dependency on create-hmac. This issue has been acknowledged and can be found in the ed25519-hd-key GitHub repository[1]. To address this limitation, the decision was made to replace ed25519-hd-key with the package ed25519-keygen[2].
Changes Made
To resolve the issue, the logic for ed25519-hd-key in the src/lib/wallet.ts file has been replaced with the logic for ed25519-keygen. This replacement ensures that the code can be executed in the browser without any dependency conflicts [2]. The changes can be found in the branch kels7-wip-make-it-work-in-the-browser)
Benefits of Using ed25519-keygen
By switching to ed25519-keygen, the following benefits are achieved:
Compatibility with browser environments, allowing the code to be executed seamlessly [2].
Pull Request Details
The pull request includes the following changes:
Replaced ed25519-hd-key with ed25519-keygen in the src/lib/wallet.ts file.
Ensured compatibility with browser environments by resolving the dependency conflict caused by create-hmac.
Pull Request Submission: Update ed25519-hd-key to ed25519-keygen
Issue Description
The npm package
ed25519-hd-key
currently cannot be run in the browser due to its dependency oncreate-hmac
. This issue has been acknowledged and can be found in the ed25519-hd-key GitHub repository [1]. To address this limitation, the decision was made to replaceed25519-hd-key
with the packageed25519-keygen
[2].Changes Made
To resolve the issue, the logic for
ed25519-hd-key
in thesrc/lib/wallet.ts
file has been replaced with the logic fored25519-keygen
. This replacement ensures that the code can be executed in the browser without any dependency conflicts [2]. The changes can be found in the branchkels7-wip-make-it-work-in-the-browser)
Benefits of Using ed25519-keygen
By switching to
ed25519-keygen
, the following benefits are achieved:Pull Request Details
The pull request includes the following changes:
ed25519-hd-key
withed25519-keygen
in thesrc/lib/wallet.ts
file.create-hmac
.