search

xianglin226 / scMDC

Single Cell Multi-omics deep clustering
Apache License 2.0
25 stars 4 forks source link

Great work, a small typo #9

Open wehos opened 9 months ago

wehos commented 9 months ago

Thank you for your great work. It seems like there is an indentation error here:

https://github.com/xianglin226/scMDC/blob/6de707dabc3a5a22ac8e707d83335f97cb979c2d/src/run_scMDC.py#L169

Can you please take a look?

wehos commented 9 months ago

Besides, there are a missing dependency munkres in README. It was used in utils.py.

fi1 and fi2 arguments, etc in Run SMAGE-seq PBMC10K script do not exist in run_scMDC.py file.

wehos commented 9 months ago

https://github.com/xianglin226/scMDC/blob/6de707dabc3a5a22ac8e707d83335f97cb979c2d/src/scMDC.py#L213

fit function here does not have t argument, but run_scMDC.py passed it here.

https://github.com/xianglin226/scMDC/blob/6de707dabc3a5a22ac8e707d83335f97cb979c2d/src/run_scMDC.py#L160

xianglin226 commented 9 months ago

Thanks for your comments. We will fix the typos soon.