xiangyue9607 / BioNEV

Graph Embedding Evaluation / Code and Datasets for "Graph Embedding on Biomedical Networks: Methods, Applications, and Evaluations" (Bioinformatics 2020)
MIT License
224 stars 77 forks source link

Include models from PyKEEN #5

Open cthoyt opened 5 years ago

cthoyt commented 5 years ago

There are several KGE models implemented in https://github.com/smartDataAnalytics/PyKEEN from @mali-git that cover translational distance models (e.g., TransE, TransH, TransR, TransD, UM, SE) and semantic matching models (e.g., RESCAL, DistMult, ERMLP, ConvE) that weren't mentioned in the README of this repo. I'm also aware that some, but not all, of these models have been made available through the packages that you've already integrated.

PyKEEN was developed with specific focus on reusability, so I hope that we can either make a PR to include a wrapper to make it work the same way as your models, or you might become interested and make use of it.

xiangyue9607 commented 5 years ago

Thanks. I like your ideas of integrating them. Since currently we are mainly focusing on revising the manuscript and adding more datasets and experiments, perhaps we can begin this task later. Feel free to email me if you want to discuss with me privately:).