search

xianmin / hugo-theme-jane

A readable & concise theme for Hugo
https://xianmin.github.io/hugo-theme-jane/
MIT License
918 stars 285 forks source link

Add Wallpaper param (plus other small improvements) #339

Closed Darthagnon closed 2 years ago

Darthagnon commented 2 years ago

It's not perfect yet, but no reason Jane-themed sites should look plain and boring.

chrome_EAp29Z3AKm

Also added wiki as submodule for downloadable documentation.

xianmin commented 2 years ago

Great thanks for your PR! I have two suggestions:

  1. We don't need docs for wiki for now, it has nothing and I think it should be deprecated... I think if we have more docs we can put them directly to the 'content/' directory in the future.
  2. put wallpaper config to full-config.toml and dev-config.toml is better. config.toml is a simple config file for new users.

Thanks again!

xianmin commented 2 years ago

I have plan to refactor this theme, and add more features, but it depends on my free time...

Darthagnon commented 2 years ago

Will implement your suggestions this weekend. EDIT: done.

Darthagnon commented 2 years ago

I can't help wondering - is it worth maintaining 2 config files? Wouldn't just 1 full config with full comments be better? NB. I'm not a professional webdev, so of course defer completely to your preference on your theme; just can't help wondering.

Darthagnon commented 2 years ago

@xianmin any more changes you'd like made, or can we get this PR merged?

xianmin commented 2 years ago

@Darthagnon Merged. Thank you! 😃