search

xiaochong / zkui

Grails ZK UI Plugin
http://grails.org/plugin/zkui
GNU Lesser General Public License v3.0
24 stars 8 forks source link

Grails 2.3.0.M1 complains about class ZkGrailsTemplateGenerator #119

Closed aaloise closed 10 years ago

aaloise commented 11 years ago

I have upgraded a grails 2.2.2 project to grails 2.3.0.M1 and after run-app grails complained about the class ZkGrailsTemplateGenerator saying this:

...\target\work\plugins\zkui-0.5.6\src\groovy\org\grails\plugins\zkui\scaffolding\ZkGrailsTemplateGenerator.groovy: 21: Can't have an abstract method in a non-abstract class. The class 'org.grails.plugins.zkui.scaffolding.ZkGrailsTemplateGenerator' must be declared abstract or the method 'void generateTest(org.codehaus.groovy.grails.commons.GrailsDomainClass, java.lang.String)' must be implemented.

Apparently changing class ZkGrailsTemplateGenerator to abstract solved the problem, but don't know if this is the best approach.

Grails 2.3.0 is still in milestone stage, but I thought it might be interesting to give a look at this particular issue.

aaloise commented 11 years ago

Making some tests I noticed that if we change ZkGrailsTemplateGenerator class to abstract it breaks the command zkui-generate-all. But if we add a method called void generateTest(GrailsDomainClass domainClass, String destdir) {} everything works just fine.

I don't know what is the purpose of this method, so in my tests I made it an empty one. Perhaps it has some needed functionality that I am not aware. I'll leave this issue open until we figure out a solid solution.

xiaochong commented 10 years ago

fix in v0.5.7