search

xiaodaigh / JDF.jl

Julia DataFrames serialization format
MIT License
90 stars 9 forks source link

type_compress #3

Closed matthieugomez closed 5 years ago

matthieugomez commented 5 years ago
xiaodaigh commented 5 years ago

Thank you for your suggedtions

xiaodaigh commented 5 years ago
  • Maybe you could compress strings to PooledDataVector, not CategoricalVector (which requires a very different syntax).

Even the official docs don't mention PooledDataVector and only mentions CategoricalVetors.

xiaodaigh commented 5 years ago
  • type_compress to compress

It's type_compress! and I think there might be other uses of compress later on for DataFrames, so I will leave it at type_compress!

matthieugomez commented 5 years ago

Which official docs?

On Fri, Sep 27, 2019 at 7:34 PM evalparse notifications@github.com wrote:

  • type_compress to compress

It's type_compress! and I think there might be other uses of compress later on for DataFrames, so I will leave it at type_compress!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xiaodaigh/JDF.jl/issues/3?email_source=notifications&email_token=ABPPPXJPGMTTNVXQ2YODTMTQL2J73A5CNFSM4I3KV62KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72KNEQ#issuecomment-536127122, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPPPXMWU7XJEQOXLRYJVV3QL2J73ANCNFSM4I3KV62A .

xiaodaigh commented 5 years ago

See latest http://juliadata.github.io/DataFrames.jl/latest/man/categorical/

Versus in DataFrames.jl v0.9 http://juliadata.github.io/DataFrames.jl/v0.9.0/man/pooling/

matthieugomez commented 5 years ago

See https://github.com/JuliaData/CategoricalArrays.jl/issues/151#issuecomment-402252366

On Fri, Sep 27, 2019 at 8:21 PM evalparse notifications@github.com wrote:

See latest http://juliadata.github.io/DataFrames.jl/latest/man/categorical/

Versus in DataFrames.jl v0.9 http://juliadata.github.io/DataFrames.jl/v0.9.0/man/pooling/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xiaodaigh/JDF.jl/issues/3?email_source=notifications&email_token=ABPPPXMPTG5DFV5XFVHTGNTQL2PRLA5CNFSM4I3KV62KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72L6FI#issuecomment-536133397, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPPPXMYW3KXFEWKCJKLUODQL2PRLANCNFSM4I3KV62A .

xiaodaigh commented 5 years ago

What am I meant to see? A high-level description please?