Add persist extension to build

[GoogleCodeExporter]

Patch attached. Thanks

Original issue reported on code.google.com by glip...@gmail.com on 4 Jul 2010 at 9:21

Attachments:

• persistbuild.diff

[GoogleCodeExporter]

Cool, thanks! Does this build properly?

Original comment by dha...@gmail.com on 5 Jul 2010 at 6:08

[GoogleCodeExporter]

Yes it did.

Original comment by glip...@gmail.com on 5 Jul 2010 at 2:47

[GoogleCodeExporter]

The POM added in 
http://code.google.com/p/google-guice/source/diff?spec=svn1200&r=1200&format=sid
e&path=/trunk/extensions/persist/pom.xml references "javax.persistence API 
1.0", whereas this patch references "javax.persistence 2.0".  Which is the 
correct one we should be using, and where is a version of the binary so we can 
include in SVN to make this patch work?

Original comment by sberlin on 1 Aug 2010 at 8:06

[GoogleCodeExporter]

To get the 1230er revision compiling the main "dist" target, I need to add one 
line to the persist extension build.xml as can be seen below. Otherwise the 
compiler can't resolve the javax.inject package.

Index: extensions/persist/build.xml
===================================================================
--- extensions/persist/build.xml    (revision 1230)
+++ extensions/persist/build.xml    (working copy)
@@ -6,6 +6,7 @@

   <path id="compile.classpath">
     <fileset dir="${lib.dir}" includes="*.jar"/>
+    <fileset dir="../../lib" includes="*.jar"/>
     <fileset dir="../../lib/build" includes="*.jar"/>
     <fileset dir="../../build/dist" includes="*.jar"/>
   </path>

Original comment by sormuras on 14 Sep 2010 at 12:20

[GoogleCodeExporter]

fixed in a slightly different way, but fixed!  see r1235

Original comment by sberlin on 16 Sep 2010 at 3:35

• Changed state: Fixed

[GoogleCodeExporter]

Unless I'm mistaken, I can't build it using ant:

C:\d\guice> ant dist
...
BUILD FAILED
C:\d\guice\build.xml:30: The following error occurred while executing this line:
C:\d\guice\common.xml:17: C:\d\guice\extensions\persist\lib\build not found.

Original comment by ogregoire on 16 Sep 2010 at 8:13

[GoogleCodeExporter]

Weird, it worked for me -- I'll take a closer look.

Original comment by sberlin on 16 Sep 2010 at 1:39

• Changed state: New

[GoogleCodeExporter]

It looks like it's the following line that should be removed, since the 
mentioned directory doesn't exist at all (at least in the repository).

guice/extensions/persist/build.xml:11 (as of r1235).

    <fileset dir="${ext.lib.dir}/build" includes="*.jar"/>

If I create the directory guice/extensions/persist/lib/build then the whole 
build works correctly.

Original comment by ogregoire on 17 Sep 2010 at 2:05

[GoogleCodeExporter]

fixed again in r1250, thanks for pointing out the problem .

Original comment by sberlin on 18 Sep 2010 at 2:53

• Changed state: Fixed