search

xiaodududu / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

Providers don't do circular dependency detection #626

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Providers can fail with StackOverflowErrors if the circular dependencies are 
purely with providers.  The current "re-entrant provider" failure only works if 
one of the dependencies didn't come from a Provider.

Providers should have full circular dependency detection, similar to how 
constructor bindings do it.

Original issue reported on code.google.com by sberlin on 30 Apr 2011 at 3:33

GoogleCodeExporter commented 9 years ago 
fixed in r=1543

Original comment by sberlin on 30 Apr 2011 at 3:38

GoogleCodeExporter commented 9 years ago 
(r1543, that is)

Original comment by sberlin on 30 Apr 2011 at 3:39

GoogleCodeExporter commented 9 years ago 
Testcase patch that shows interesting conflict wrt. circular provider proxies 
and injection listeners

Original comment by mccu...@gmail.com on 4 May 2011 at 6:03

Attachments: