search

xiaodududu / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

Pull Guava out from jarjar and attach it as a normal dependency. #709

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Guava has been releasing open-source versions for a couple of years now, and 
has solid guarantees about non-@Beta APIs staying consistent over a long period 
of time.  Guice doesn't need to package Guava into an internal package any 
longer.  

(Note that for bytecode manipulation stuff and other bits, we'll keep them 
internal)

Original issue reported on code.google.com by cgruber@google.com on 5 Jun 2012 at 3:07

GoogleCodeExporter commented 9 years ago 
Candidate patch, tested locally

Original comment by mccu...@gmail.com on 29 Jul 2012 at 4:05

Attachments:

GoogleCodeExporter commented 9 years ago 
Issue 689 has been merged into this issue.

Original comment by mccu...@gmail.com on 16 Oct 2013 at 10:09

GoogleCodeExporter commented 9 years ago 
Latest patch against HEAD

Original comment by mccu...@gmail.com on 9 Dec 2013 at 6:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Issue 719 has been merged into this issue.

Original comment by mccu...@gmail.com on 3 Jan 2014 at 1:00

GoogleCodeExporter commented 9 years ago 
Updated patch that externalizes Guava as a dependency and cleans up the jarjar 
invocations. The Maven build now attaches the original un-jarjar'd classes 
using classifier "classes" in case people want to replace ASM/CGLIB with a 
different version.

https://code.google.com/r/mcculls-google-guice/source/detail?r=fc6dde6131da92cfb
0150c300aa6ef77180944fe&name=Issue-709-ExternalizeGuava

Original comment by mccu...@gmail.com on 20 Jan 2014 at 12:02

GoogleCodeExporter commented 9 years ago 
I've incorporated this patch into another change I'm making, which bumps Guava 
to 16.  i'm OOO this week, but I have something more or less ready.  Shoudl be 
reviewed and fixed up by early next week.

Original comment by christia...@gmail.com on 7 Feb 2014 at 12:08

GoogleCodeExporter commented 9 years ago 
@mcculls' change pulled into a larger change 
(https://code.google.com/p/google-guice/source/detail?r=3236b100a95b739577dfcd11
7c24615370a1d0af) which also bumps Guava to 16.0.1.

Original comment by christia...@gmail.com on 14 Feb 2014 at 5:51