Update internal caches to use Guava's CacheBuilder API

xiaodududu / google-guice

Automatically exported from code.google.com/p/google-guice

Apache License 2.0

0 stars 0 forks source link

Update internal caches to use Guava's CacheBuilder API #760

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Because makeComputingMap is deprecated in favour of CacheBuilder going forwards

Original issue reported on code.google.com by mccu...@gmail.com on 8 Aug 2013 at 10:39

GoogleCodeExporter commented 9 years ago

Suggested patch that switches internal caches to use the CacheBuilder API. 
Note: there may be additional cache settings that should be enabled or tuned, 
and other improvements in the codebase that could be made because of the richer 
caching API.

Original comment by mccu...@gmail.com on 8 Aug 2013 at 10:44

Attachments:

GUICE_760_switch_to_cachebuilder.patch

GoogleCodeExporter commented 9 years ago

See also http://code.google.com/p/guava-libraries/wiki/MapMakerMigration

Original comment by mccu...@gmail.com on 8 Aug 2013 at 10:49

GoogleCodeExporter commented 9 years ago

Latest patch against master

Original comment by mccu...@gmail.com on 12 Sep 2013 at 9:54

Attachments:

GUICE_760_switch_to_cachebuilder.patch

GoogleCodeExporter commented 9 years ago

Original comment by cgruber@google.com on 12 Sep 2013 at 9:28

Changed state: Accepted
Added labels: Type-CodeQuality, Milestone-Release4.0

GoogleCodeExporter commented 9 years ago

Thanks Stuart.  I'll try to get this in this week.

Original comment by cgruber@google.com on 12 Sep 2013 at 9:28

GoogleCodeExporter commented 9 years ago

Issue 769 has been merged into this issue.

Original comment by mccu...@gmail.com on 16 Oct 2013 at 10:11