git add --patch fails -- missing Error.pm

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Install git using the 1.7.6 snow leopard x86_64 installer on 10.6.8
2. Create a git repository with at least one committed file in it or clone an 
existing one
3. Modify a tracked file and then run git add --patch

What is the expected output? What do you see instead?

1. You should get the interactive terminal add prompt.
2. Instead you get:

Can't locate Error.pm in @INC (@INC contains: 
/usr/local/git/lib/perl5/site_perl 
/Library/Perl/Updates/5.10.0/darwin-thread-multi-2level 
/Library/Perl/Updates/5.10.0 
/System/Library/Perl/5.10.0/darwin-thread-multi-2level 
/System/Library/Perl/5.10.0 /Library/Perl/5.10.0/darwin-thread-multi-2level 
/Library/Perl/5.10.0 /Network/Library/Perl/5.10.0/darwin-thread-multi-2level 
/Network/Library/Perl/5.10.0 /Network/Library/Perl 
/System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level 
/System/Library/Perl/Extras/5.10.0 .) at 
/usr/local/git/lib/perl5/site_perl/Git.pm line 101.
BEGIN failed--compilation aborted at /usr/local/git/lib/perl5/site_perl/Git.pm 
line 101.
Compilation failed in require at 
/usr/local/git/libexec/git-core/git-add--interactive line 7.
BEGIN failed--compilation aborted at 
/usr/local/git/libexec/git-core/git-add--interactive line 7.

What version of the product are you using? On what operating system?

1. Installed git-1.7.6-x86_64-snow-leopard.dmg from this site
2. On a fully patched version of 10.6.8 Snow Leopard

Please provide any additional information below.

1. Downloading the latest version of Error (from 
http://search.cpan.org/~shlomif/Error-0.17016/ which is currently 
http://search.cpan.org/CPAN/authors/id/S/SH/SHLOMIF/Error-0.17016.tar.gz) and 
unpacking and then copying the lib/Error.pm file out of the .tar.gz file and 
into /usr/local/git/lib/perl5/site_perl (so that you now have a 
/usr/local/git/lib/perl5/site_perl/Error.pm file) fixes the problem and then 
git add --patch works fine.

2. The git-1.7.6-i386-snow-leopard.dmg installer from this site doesn't install 
Error.pm either so I expect it will fail the same way.

3. Please add Error.pm to the installers (it's only 24829 bytes).

4. This likely affects all Perl-based git commands since Git.pm fails to load

Original issue reported on code.google.com by mack...@gmail.com on 1 Sep 2011 at 3:59

[GoogleCodeExporter]

As discussed offline, it s will have the installer place the provided (but not 
installed by default) private-Error.pm as 
/usr/local/git/lib/perl5/site_perl/Error.pm

Original comment by timchar...@gmail.com on 4 Sep 2011 at 2:39

• Changed state: Accepted

[GoogleCodeExporter]

Ok, I just uploaded git 1.7.6.1. From now on, we will ensure that Error.pm is 
included! Please test and see if it resolves issues for you. Thanks so much for 
the help getting this fixed.

Original comment by timchar...@gmail.com on 4 Sep 2011 at 4:11

• Changed state: Fixed

[GoogleCodeExporter]

I removed /usr/local/git from my 1.7.6 installation and then ran the 1.7.6.1 
installer and tested git add --patch and it works great now!

Thanks for fixing this. :)

Original comment by mack...@gmail.com on 4 Sep 2011 at 2:10