xiaohuilam / laravel-admin-select2

π’‚π’”π’šπ’π’„ 𝒔𝒆𝒍𝒆𝒄𝒕/π’Žπ’π’“π’‘π’‰π‘Ίπ’†π’π’†π’„π’• 𝒇𝒐𝒓 𝒍𝒂𝒓𝒂𝒗𝒆𝒍 π’‚π’…π’Žπ’Šπ’
MIT License
41 stars 4 forks source link

Travis CI Fail: Trying to access array offset on value of type int #38

Closed xiaohuilam closed 5 years ago

xiaohuilam commented 5 years ago
$ php --version
PHP 7.4.0-dev (cli) (built: Jul 17 2019 10:13:28) ( ZTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.0-dev, Copyright (c), by Zend Technologies
$ composer --version
Composer version 1.8.6 2019-06-11 15:03:05

$ ./vendor/bin/phpcs
...................... 22 / 22 (100%)
Time: 148ms; Memory: 8MB
The command "./vendor/bin/phpcs" exited with 0.
0.28s$ ./vendor/bin/phpunit
PHPUnit 7.5.14 by Sebastian Bergmann and contributors.
EEEEEEEEE                                                           9 / 9 (100%)
Time: 178 ms, Memory: 18.00 MB
There were 9 errors:
1) LaravelAdminExt\Select2\Test\MorphSelectApiTest::testForm
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MorphSelectApiTest.php:18
2) LaravelAdminExt\Select2\Test\MorphSelectApiTest::testMatch
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MorphSelectApiTest.php:18
3) LaravelAdminExt\Select2\Test\MorphSelectApiTest::testText
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MorphSelectApiTest.php:18
4) LaravelAdminExt\Select2\Test\MultipleSelectApiTest::testForm
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MultipleSelectApiTest.php:18
5) LaravelAdminExt\Select2\Test\MultipleSelectApiTest::testMatch
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MultipleSelectApiTest.php:18
6) LaravelAdminExt\Select2\Test\MultipleSelectApiTest::testText
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/MultipleSelectApiTest.php:18
7) LaravelAdminExt\Select2\Test\SelectApiTest::testForm
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/SelectApiTest.php:18
8) LaravelAdminExt\Select2\Test\SelectApiTest::testMatch
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/SelectApiTest.php:18
9) LaravelAdminExt\Select2\Test\SelectApiTest::testText
ErrorException: Trying to access array offset on value of type int
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Input/Input.php:55
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:208
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/symfony/console/Application.php:149
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:90
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Console/Application.php:182
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275
/home/travis/build/xiaohuilam/laravel-admin-select2/vendor/laravel/browser-kit-testing/src/Concerns/InteractsWithConsole.php:25
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/AbstractTestCase.php:72
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/Menu.php:11
/home/travis/build/xiaohuilam/laravel-admin-select2/tests/SelectApiTest.php:18
ERRORS!
Tests: 9, Assertions: 0, Errors: 9.
The command "./vendor/bin/phpunit" exited with 2.
Done. Your build exited with 1.
xiaohuilam commented 5 years ago

seems same reason because dependency of laravel-acl https://github.com/jungessolutions/laravel-acl/issues/111

xiaohuilam commented 5 years ago

The symfony/console ArrayInput.php seems not a most recently modified file, instead nine years ago.

https://github.com/symfony/console/blame/18d6e02/Input/ArrayInput.php#L134-L145

so, i think it might be the exception caused by php 7.4 latest-added feature

mateusjunges commented 5 years ago

Hi @xiaohuilam First of all, thanks for use my package!

Are you having troubles withthe mateusjunges/laravel-acl#111 issue?

The package tests passes for all PHP 7.1, 7.2 and 7.3 test cases, but the installation command tests fail for php 7.4 with this error:

1) Junges\ACL\Tests\Commands\InstallCommandTest::test_installation_command
ErrorException: Trying to access array offset on value of type int

/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Input/Input.php:55
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Application.php:208
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Application.php:149
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Console/Application.php:89
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Console/Application.php:188
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:250
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/PendingCommand.php:136
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/PendingCommand.php:220
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithConsole.php:55
/home/travis/build/jungessolutions/laravel-acl/tests/Commands/InstallCommandTest.php:21

Since PHP 7.4 is not released yet, i'm not giving so much importance for that issue for now. I fixed some bugs with version 2, and you can check it out here.

I'll fix this issue as soon as possible.

xiaohuilam commented 5 years ago

Hi @xiaohuilam First of all, thanks for use my package!

Are you having troubles withthe mateusjunges/laravel-acl#111 issue?

The package tests passes for all PHP 7.1, 7.2 and 7.3 test cases, but the installation command tests fail for php 7.4 with this error:

1) Junges\ACL\Tests\Commands\InstallCommandTest::test_installation_command
ErrorException: Trying to access array offset on value of type int

/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Input/ArrayInput.php:135
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Input/Input.php:55
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Application.php:208
/home/travis/build/jungessolutions/laravel-acl/vendor/symfony/console/Application.php:149
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Console/Application.php:89
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Console/Application.php:188
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:250
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/PendingCommand.php:136
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/PendingCommand.php:220
/home/travis/build/jungessolutions/laravel-acl/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithConsole.php:55
/home/travis/build/jungessolutions/laravel-acl/tests/Commands/InstallCommandTest.php:21

Since PHP 7.4 is not released yet, i'm not giving so much importance for that issue for now. I fixed some bugs with version 2, and you can check it out here.

I'll fix this issue as soon as possible.

Symfony/console fixed this error today. https://github.com/symfony/symfony/pull/32806

mateusjunges commented 5 years ago

Thanks!

xiaohuilam commented 5 years ago

Now fixed