search

xiaokai-wang / nginx-stream-upsync-module

For stream protocol. syncing upstreams from etcd or consul and so on, dynamically updating backend servers attribute, not need to reload nginx for tcp protocol, stream configure.
175 stars 48 forks source link

bugfix for ngx_stream_upsync_del_peers #42

Closed fishgege closed 4 years ago

fishgege commented 4 years ago

bugfix: 解决在删除peer 时，无匹配项 引发空指针引用产生的coredump

xiaokai-wang commented 4 years ago

@fishgege thanks.

gfrankliu commented 4 years ago

Is the same fix needed here? https://github.com/weibocom/nginx-upsync-module/blob/master/src/ngx_http_upsync_module.c#L1156

xiaokai-wang commented 4 years ago

@gfrankliu I am not sure, it's never issued about the module of nginx-upsync-module.

fishgege commented 4 years ago

Is the same fix needed here? https://github.com/weibocom/nginx-upsync-module/blob/master/src/ngx_http_upsync_module.c#L1156

Yeah， I think so, if the variable tmp_del_peer not be setted before used, then coredump will come. @gfrankliu @xiaokai-wang

gfrankliu commented 4 years ago

https://github.com/xiaokai-wang/nginx-stream-upsync-module/issues/41