search

xiaolei-lab / SIMER

Data Simulation for Life Science and Breeding
Apache License 2.0
27 stars 8 forks source link

Suggest: add tests and CI #2

Closed richelbilderbeek closed 3 years ago

richelbilderbeek commented 3 years ago

Dear SIMER maintainers, hi @XiaoleiLiuBio,

SIMER seems to have much potential and I consider becoming an early user of it. What holds me back are the lack of tests and the absence of a continuous integration service (such as GitHub Actions).

Are there plans to add these, so others can be convinced of the correctness of SIMER? If yes, I do volunteer to help if requested.

XiaoleiLiuBio commented 3 years ago

Thank you very much for your suggestions. We agree that tests are very important. Recently, we have made abundant tests on SIMER, e.g., to test if SIMER can simulate a phenotype with a given heritability and variance, and also compared the simulation accuracy with existing tools. After we finished the main functions, we will try to add the tests, maybe in a couple of months.

richelbilderbeek commented 3 years ago

Happy to hear that tests are valued!

Recently, we have made abundant tests on SIMER

I cannot find these in the repo. Is there a seperate repo just for testing?

And what about Continuous Integration?

XiaoleiLiuBio commented 3 years ago

We haven't added the tests in the repo at present. The tests will be added after we finished the tests.

I didn't have any experience with CI, and will think about it later.

richelbilderbeek commented 3 years ago

The tests will be added after we finished the tests.

Nice, looking forward to that!

If you want, I can volunteer to add CI, as it will not take too long for me.

In any case, go ahead and close this Issue after reading this :+1:

XiaoleiLiuBio commented 3 years ago

I will let you know if we need any help from you. Thank you in advance!