search

xiaolu / lz4

Automatically exported from code.google.com/p/lz4
1 stars 1 forks source link

Compiler error on VC2005 for WinCE #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
According to the msdn page: 
http://msdn.microsoft.com/en-us/library/ms253923%28v=vs.80%29.aspx

VC device compiler are not support bit-scan intrinsics.

So LZ4_FORCE_SW_BITCOUNT should be defined if _MSC_VER and _WIN32_WCE are both 
defined.

Original issue reported on code.google.com by baiyang@gmail.com on 12 Apr 2012 at 9:47

GoogleCodeExporter commented 9 years ago 
intrin.h not exists for WinCE env too, so the "include <intrin.h>" directive 
should also be protected by the macro.

Original comment by baiyang@gmail.com on 12 Apr 2012 at 9:49

GoogleCodeExporter commented 9 years ago 
I will handle it.
The main issue is that i won't be able to test it (lacking suitable WinCE dev 
environment) but can nonetheless propose a patch for this well-defined case.

Original comment by yann.col...@gmail.com on 3 May 2012 at 2:00

GoogleCodeExporter commented 9 years ago 
Actually you can test it very easy, Because It's a COMPILING time error, not a 
runtime one.

So you don't need a CE device, just select an appropriate target paltform and 
do the compiling is enough.

Original comment by baiyang@gmail.com on 3 May 2012 at 2:12

GoogleCodeExporter commented 9 years ago 
You'll find in attached file a proposed modification of LZ4 to handle issue 17.
It should now automatically select SW_BITCOUNT for Visual + WinCE.
Actually, i can't test it, because my versions of Visual do not allow me to 
select a CE target. All i can say is that it seems to not break anything on PC 
target.

As a sidenote, the list of unsupported intrinsic of Visual 2005 is also 
documented for Visual 2008, but not for Visual 2010. Maybe a sign of vanishing 
support for WinCE ?

Original comment by yann.col...@gmail.com on 8 May 2012 at 9:13

Attachments:

GoogleCodeExporter commented 9 years ago 
I have been tested the attachment and it's ok :-)

But I could not found VS 2010 option in the "Other Version" drop box. There are 
only VS2005 and VS2008 in that page.

I'm even not sure that does VS2010 support WinCE target any more?

Original comment by baiyang@gmail.com on 9 May 2012 at 9:58

GoogleCodeExporter commented 9 years ago 
Corrected into r64

Original comment by yann.col...@gmail.com on 9 May 2012 at 11:51