search

xiaomi7732 / StackBeauty

Format stack, make it easy to read and understand
https://stack.codewithsaar.net
MIT License
5 stars 1 forks source link

Fix premature return #15

Closed JacobBovee closed 2 years ago

JacobBovee commented 2 years ago

The dev backend is currently returning an empty array for most of the stacks on the Portal. This is due to a premature return that should be a break; returning false for any stack with an unparsable line.

Example breaking stack for testing:

Type System.String
mscorlib.ni!System.String.InternalSubString(Int32, Int32)
mscorlib.ni!System.String.Substring(Int32, Int32)
diagservice!DiagService.Runners.StringOperationRunner.Run(int32,value class DiagService.OperationEnum)
diagservice!DiagService.Controllers.MemoryController.StringSubstring(int32)
anonymously hosted dynamicmethods assembly!dynamicClass.lambda_method(pMT: 6FEF0FF8,class System.Object,class System.Object[])
system.web.http!System.Web.Http.Controllers.ReflectedHttpActionDescriptor+ActionExecutor.Execute(class System.Object,class System.Object[])
system.web.http!System.Web.Http.Controllers.ApiControllerActionInvoker+<InvokeActionAsyncCore>d__1.MoveNext()
mscorlib!System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[System.__Canon].Start(!!0&)