xiaomi7732 / StackBeauty

Format stack, make it easy to read and understand
https://stack.codewithsaar.net
MIT License
5 stars 1 forks source link

Refactor: Think about IPreFilter, is there a way to make it more general #6

Closed xiaomi7732 closed 2 years ago

xiaomi7732 commented 2 years ago

Imaging 2nd IPreFilter, and asking 2 questions:

  1. Does it make sense to having the line text and line number?
  2. Does it make sense for the callers to provide those for other preFilters?

If no, what's the best way to abstract?

Details:

https://github.com/xiaomi7732/StackBeauty/blob/5f1f25a0c351b0fbcfc3b5e0f378ad0257e39d81/NetStackBeautifier.Services/Filters/IPreFilter.cs#L8