Closed zengjiwen closed 3 years ago
@xiaonanln
- 修复迁移目的位置错误bug
- 代码优化
Thanks for the fix.
Please fix the build errors. I would recommend to not include unrelated changes. @zengjiwen
Please fix the build errors. I would recommend to not include unrelated changes. @zengjiwen
ok
I'll fix the migrate test err later.
Merging #109 (c8290d4) into master (cd57cc9) will decrease coverage by
1.42%
. The diff coverage is14.89%
.
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 34.22% 32.80% -1.43%
==========================================
Files 41 37 -4
Lines 3708 2576 -1132
==========================================
- Hits 1269 845 -424
+ Misses 2277 1609 -668
+ Partials 162 122 -40
Impacted Files | Coverage Δ | |
---|---|---|
engine/async/async.go | 71.05% <ø> (-1.29%) |
:arrow_down: |
engine/entity/EntityManager.go | 18.77% <ø> (+1.16%) |
:arrow_up: |
engine/entity/MapAttr.go | 37.39% <ø> (+0.83%) |
:arrow_up: |
engine/entity/Space.go | 0.00% <ø> (ø) |
|
engine/entity/SpaceManager.go | 28.57% <ø> (+8.57%) |
:arrow_up: |
engine/entity/rpc_desc.go | 61.11% <ø> (-2.05%) |
:arrow_down: |
engine/gwlog/gwlog.go | 81.03% <ø> (+0.51%) |
:arrow_up: |
engine/kvdb/kvdb.go | 31.03% <0.00%> (-3.28%) |
:arrow_down: |
engine/kvreg/kvreg.go | 0.00% <ø> (ø) |
|
engine/netutil/Connection.go | 0.00% <ø> (-100.00%) |
:arrow_down: |
... and 44 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca7fe60...c8290d4. Read the comment docs.