xiaorouji / openwrt-passwall

7.06k stars 2.62k forks source link

即使不选择passwall,trojan-plus等组件也会默认编译 #2106

Closed saldry closed 2 years ago

saldry commented 2 years ago

描述bug(必填)

luci-app-passwall的Makefile里默认了Trojan_Plus等组件

define Package/$(PKG_NAME)/config
menu "Configuration"
...
config PACKAGE_$(PKG_NAME)_INCLUDE_Trojan_Plus
    bool "Include Trojan-Plus"
    default y
...
endmenu
endef

编译时即使没有选择luci-app-passwall,也会默认带上trojan-plus。也就是.config中:

# CONFIG_PACKAGE_luci-app-passwall  is not set
...
CONFIG_PACKAGE_luci-app-passwall_INCLUDE_Trojan_Plus=y

如果保持默认,即使是不需要出国功能的设备,也会编译上trojan-plus,只能在编译时主动否掉CONFIG_PACKAGE_luci-app-passwall_INCLUDE_Trojan_Plus

CONFIG_PACKAGE_luci-app-passwall_INCLUDE_Trojan_Plus应该是passwall的附属组件,不选择passwall就不应该被默认添加。

复现步骤(必填)

  1. 在.config中填入
    CONFIG_TARGET_x86=y
    CONFIG_TARGET_x86_64=y
    CONFIG_TARGET_x86_64_DEVICE_generic=y
  2. make defconfig
  3. 打开.config,发现
    # CONFIG_PACKAGE_luci-app-passwall  is not set
    ...
    CONFIG_PACKAGE_luci-app-passwall_INCLUDE_Trojan_Plus=y
  4. 编译后的镜像包含了trojan-plus

你想要实现的目的(必填)

编译时如果不选择luci-app-passwall,CONFIG_PACKAGE_luci-app-passwall_INCLUDE_相关组件就不会被默认编译。

其他相关信息

github-actions[bot] commented 2 years ago

@saldry: hello! :wave:

This issue is being automatically closed because it does not follow the issue template.