xiaoruiDong / RDMC

Reaction Data and Molecular Conformers (RDMC) is a package dealing with reactions, molecules, conformers, majorly in 3D.

https://xiaoruidong.github.io/RDMC/

MIT License

21 stars 0 forks source link

cached_property was only introduced from python 3.8 #87

Closed shihchengli closed 3 months ago

shihchengli commented 3 months ago

Description

The cached_property is used in base.py, and it is implemented in the functools package since python 3.8 (See here). However, RDMC allows python version >=3.6.

Bug description

When using RDMC in python 3.7 (or lower version), ImportError: cannot import name 'cached_property' from 'functools' would appear.

xiaoruiDong commented 3 months ago

@shihchengli Good catch. I am also aware of that, but I haven't implemented it yet.

I plan to stop the support of Python 3.6 right now (as it reached end-of-life on Dec 23, 2021). Also, stop the support of Python 3.7 as its EOL is Jun 27, 2023, but will hold a little bit until RMG gets upgraded to Python 3.8+. Within 6 months, we will get to the EOL of Python 3.8, so I may also stop the support of it afterward.