xiaoruiDu / TSMM

MIT License
10 stars 3 forks source link

Changing Parameters #2

Open midick opened 1 year ago

midick commented 1 year ago

This code is an absolute godsend for me. I do have one question though: in the paper (https://www.cms-labs.org/bib/meng2022topologypreserving/meng2022topologypreserving.pdf) you refer to several parameters the user might want to change depending on their use-case, like: street density when elongating lines or the handling of intersections. Where would one change these parameters in your code?

Mengzhuoxiao commented 1 year ago

Hi, You can adjust the parameters here: https://github.com/xiaoruiDu/TSMM/blob/1e673ee388e5e28fe02deb7a03c8a23a16e19fd5/TSMM_libcommon/src/OSMHandler.cpp#L21-L26

The parameter-tunning is hard-coded, unfortunately.

midick commented 1 year ago

ah perfect! Thank you so much! is there something similar for the handling of intersections?

Mengzhuoxiao commented 1 year ago

Hi, what do you mean by "handling of intersections"?

midick commented 1 year ago

on page 9 of your paper you say "Users of TSMM can therefore define which type of street should be served with interchange." but I couldn't figure out where to do this.

midick commented 1 year ago

For example when I start with a network like this: initial_network.pdf which is a part of Istanbul with only secondary and larger roads and run tsmm on this I get the following results for the first three steps: 01_link_ways__allLayer.pdf 02_first_buffer__allLayer.pdf 03_re_buffer__allLayer.pdf

and then in the fifth step something goes horribly wrong: 05_extend__allLayer.pdf

Leaving me with the end result: 12_final__allLayer.pdf

Do you have an idea how I could solve this?

xiaoruiDu commented 1 year ago

Thank you for bringing up the issue. We suspect that the code is not working properly due to the roundabout illustrated below. , as we also mentioned in our paper (chapter 6).

image

Regrettably, we are currently occupied with other projects and may not be able to devote much time to investigate it further. However, we would greatly appreciate it if you could help us out with this. Please feel free to continue the discussion in this thread.