Cancel and Apply buttons not working as expected

[GoogleCodeExporter]

What steps will reproduce the problem?
1.make changes to settings
2.press cancel 

Changes to settings are saved anyways after canceling.

Apply button should be grayed-out before any changes is made and after the 
changes have been applied.

v3.0.0.211, xpsp3

Thanks.

Original issue reported on code.google.com by tekk...@gmail.com on 12 Dec 2012 at 5:39

[GoogleCodeExporter]

> Changes to settings are saved anyways after canceling.

If you uncheck "Apply changes immediately" on the Misc tab, this shouldn't 
occur.

> Apply button should be grayed-out

We'll look into this.

Original comment by cyber.sp...@gmail.com on 14 Dec 2012 at 9:32

• Changed title: Cancel and Apply buttons not working as expected
• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Original comment by cyber.sp...@gmail.com on 14 Dec 2012 at 9:33

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

After unchecking "Apply changes immediately" on the Misc tab, I did some more 
testing.

1. On main tab, "only show forced subtitles" unchecked to checked
2. switch to general tab and press cancel
3. Reopen the properties window
4. "only show forced subtitles" would be checked.

thanks.

Original comment by tekk...@gmail.com on 15 Dec 2012 at 3:52

[GoogleCodeExporter]

Did you make sure that "Apply changes immediately" was unchecked, applied, and 
the dialog closed before doing those steps?

Please test this again, because I can't reproduce this on Win7 SP1 x64 or WinXP 
SP3 x86.

Original comment by cyber.sp...@gmail.com on 15 Dec 2012 at 10:48

[GoogleCodeExporter]

Please do not be confused. First, let me clarify...

At first, I didn't uncheck "Apply changes immediately" on the Misc tab. That's 
my fault it saved.

After your guidance, I unchecked "Apply changes immediately" on the Misc tab. 
Now it only get saved when I switch the tabs(make changes on first tab, switch 
to 2nd tab, cancel).

I am using WinXP SP3 x86, too. I even tried it with these commands in a batch 
file.

@echo off
cd /d %~dp0
regsvr32 /u /s VSFilter.dll
regsvr32 /s VSFilter.dll
start rundll32 VSFilter.dll,DirectVobSub

I am suspecting that the changes are saved right away as you change the tab.

If you can't reproduce it, maybe it's just my machine. Thanks anyways as it's 
not a big deal.

Original comment by tekk...@gmail.com on 16 Dec 2012 at 12:58

[GoogleCodeExporter]

Okay, I think I'm able to reproduce it now.

It seems to only occur when you access the offline Properties page of VSFilter 
via the installer's Configuration shortcut (rundll32 VSFilter.dll,DirectVobSub)

When you access the online Properties of VSFilter from an active directshow 
graph (like via MPC-HC's filter's context menu), it works as expected. 

Since both these issues also occur in VSFilter.dll 2.41 from MPC-HC, I'd 
recommend reporting this to their bug tracker: 
http://sourceforge.net/apps/trac/mpc-hc/wiki/Bugs_-_Reporting

If reported to MPC-HC, there would be a good chance of them resolving these 
issues before our own developer returns in mid-January.

Original comment by cyber.sp...@gmail.com on 16 Dec 2012 at 4:56