Need to use system-provided tuple on VS 2010

xiaowanmay / googletest

Automatically exported from code.google.com/p/googletest

0 stars 0 forks source link

Need to use system-provided tuple on VS 2010 #217

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

googletest seems to define parts of C++0x's TR1 tuple library, making it
incompatible with modern C++0x compilers. For instance, VS2010 B2's cl.exe
enables C++0x by default, so it's probably important to get this resolved
soon! One rudimentary solution could be to check for predefined macros
identifying the compiler.

Original issue reported on code.google.com by yanghate...@gmail.com on 6 Nov 2009 at 5:39

GoogleCodeExporter commented 9 years ago

VS 2010 is not yet released, and its support for tr1::tuple may change in the 
final 
release. So we are not supporting it yet.  The workaround for unsupported 
compilers is 
described in gtest-port.h: just define the preprocessor symbol 
GTEST_USE_OWN_TR1_TUPLE=0 in the command line for your compiler.

Original comment by vladlosev on 12 Nov 2009 at 5:42

Changed state: WontFix

GoogleCodeExporter commented 9 years ago

Issue 225 has been merged into this issue.

Original comment by vladlosev on 23 Nov 2009 at 11:59

GoogleCodeExporter commented 9 years ago

This ahs been reported by more people, so I am reopening the issue. Please 
report the
value of the _MSC_VER symbol defined by the Visual Studio 2010 C++ compiler. It 
is be
needed for the fix.

Original comment by vladlosev on 24 Nov 2009 at 12:02

Changed state: Accepted
Added labels: Component-Logic, OpSys-Windows, Priority-Low, Usability
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

_MSC_VER 1600

Thanks

Original comment by litgh...@gmail.com on 24 Nov 2009 at 12:20

GoogleCodeExporter commented 9 years ago

It's worth noting I searched for 2010 and it hadn't come up because I had 
searched
open issues.

Original comment by litgh...@gmail.com on 24 Nov 2009 at 12:27

GoogleCodeExporter commented 9 years ago

Original comment by vladlosev on 29 Nov 2009 at 11:24

Changed title: Need to use system-provided tuple on VS 2010

GoogleCodeExporter commented 9 years ago

Issue 226 has been merged into this issue.

Original comment by vladlosev on 29 Nov 2009 at 11:25

GoogleCodeExporter commented 9 years ago

Fixed in r362.

Original comment by w...@google.com on 5 Jan 2010 at 8:45

GoogleCodeExporter commented 9 years ago

Actually, it's r364.

Original comment by w...@google.com on 8 Jan 2010 at 12:24

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Issue 276 has been merged into this issue.

Original comment by vladlosev on 14 Apr 2010 at 3:22

GoogleCodeExporter commented 9 years ago

Still an issue with Microsoft Visual Studio 2010, which has now been released.

Original comment by tony.can...@gmail.com on 11 Sep 2010 at 8:03

GoogleCodeExporter commented 9 years ago

What version of library are you using and what are the error messages?

Original comment by vladlosev on 12 Sep 2010 at 9:45

GoogleCodeExporter commented 9 years ago

All you need to do to fix this, is to have gtest-tuple.h not define 
std::tr1::tuple, rahter #include <tuple>

Original comment by michael....@gmail.com on 31 May 2011 at 3:40

GoogleCodeExporter commented 9 years ago

Thanks for sharing information about this build error. The final release VS 
2010 Pro continues to fail on the gtest tuple definition.  I've attached a 
modified gtest-tuple.h file which works on VS2010 and should also work on 
VS2008. It wraps the tuple definition around an "#if _MSC_VER < 1600" block. 
VS2010's _MSC_VER is.. you guessed it 1600.

It would be great if this could be incorporated into the gtest release.

Original comment by peacemon...@gmail.com on 26 Aug 2011 at 10:37

Attachments:

gtest-tuple.h