xiaoxiaoflood / firefox-scripts

userChromeJS / autoconfig.js and extensions
Mozilla Public License 2.0
944 stars 83 forks source link

MinMaxClose button is not supporting dark mode #214

Closed Aleksandra0056 closed 1 year ago

Aleksandra0056 commented 1 year ago

Actual results: With dark mode enabled, the MinMaxClose button is black.

Expected results: With dark mode enabled, the MinMaxClose button should be white.

Environment: Windows 11 22621.963, 64-bit Firefox 108.0.1

xiaoxiaoflood commented 1 year ago

Can you test this change in your Firefox? Because after I was updating that .js file in my chrome folder, I got this:

Broken MinMaxClose button

Works for me. image

Aleksandra0056 commented 1 year ago

Well, then it is issue in my side, sorry.

xiaoxiaoflood commented 1 year ago

If you can get reliable steps to reproduce your issue from a fresh new profile, post it here and I'll try to fix.

Aleksandra0056 commented 1 year ago

Yes, I am able to reproduce it even in new profile.

Aleksandra0056 commented 1 year ago
  1. Create new profile
  2. Open about:support and create in profile folder new folder called chrome
  3. Download utils with extensions and scripts, but do not copy the scripts, but copy only utils folder and rebuild_userChrome.uc.js into chrome
  4. Clear startup cache
  5. Now add scripts into chrome folder
  6. Clear startup cache again
  7. Issue should be now reproducible
Aleksandra0056 commented 1 year ago

And can you tell me, where are the icons for MinMaxClose stored?

xiaoxiaoflood commented 1 year ago

Thanks. Now it's fixed.

And can you tell me, where are the icons for MinMaxClose stored?

dataURI

Search for

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAO0lEQVQ4jWNgYGD4jwWTBCg2gBSDSTKcYgNwGUqRzfQzAJcYxQYQBahiAE0SF7pBVEn2VHEJ/VyANQwACylDvQ9eqkEAAAAASUVORK5CYII=

in the code.

Copy the entire line above, paste it alone in address bar, press Enter and you'll see the icon.

Aleksandra0056 commented 1 year ago

Thank you, now it is working.