search

xiaoxiaoflood / firefox-scripts

userChromeJS / autoconfig.js and extensions
Mozilla Public License 2.0
1.02k stars 86 forks source link

DownThemAll no longer functions under Nightly 115.0a1 starting 2023-05-13 #259

Open jiangzhenjerry opened 1 year ago

jiangzhenjerry commented 1 year ago

Starting Nightly 2023/05/13 morning build, DownThemAll no longer functions. It's enabled under Extensions, but doesn't show up under the right-click context menu or the main menu -> Tools.

The last Nightly build that works well with DownThemAll is 2023/05/12 afternoon build.

xelsios commented 1 year ago

OS.File got removed which is used in DTA https://hg.mozilla.org/mozilla-central/rev/c698636dbfea4e9d7a50338981b7a4862404ea92

jiangzhenjerry commented 1 year ago

Thanks @xelsios for the information. Does it mean DTA is doomed to death due to this change?

xelsios commented 1 year ago

Fortunately not. I managed to get DTA working again! There may be some bugs that I missed, but in the normal use case it should work fine.

Tested with Nightly Build ID 20230527212147

DownThemAll-3.1.2.113.2023.05.28-xiao.xpi.zip

jiangzhenjerry commented 1 year ago

@xelsios Thanks a lot! Great news 😁

marty60 commented 1 year ago

Nice job xelsios, DTA is back. 😁

jiangzhenjerry commented 1 year ago

@xelsios Bug report: "Set file time to last modified time (server) or time of queuing" doesn't work properly. For any file, the first time DTA downloads it, DTA does not retrieve the server timestamp, so the file time is set to the time of queuing. But if I immediately re-download the file, DTA retrieves the server time correctly.

2023-05-28_193021
xelsios commented 1 year ago

@jiangzhenjerry First I was not able to reproduce the error on my machine, after testing in an fresh VM I found the source of this problem. Hope this will fix it for you also.

DownThemAll-3.1.2.113.2023.05.29-xiao.xpi.zip

jiangzhenjerry commented 1 year ago

@xelsios Fix confirmed. Thank you! :)

jiangzhenjerry commented 1 year ago

@marty60 I'm on the latest Nightly (still 115.0a1 but probably will bump up to 116.0a1 later today), and don't have the issues you mentioned. Will keep you updated once Firefox upgrades to 116.0a1.

marty60 commented 1 year ago

@marty60 I'm on the latest Nightly (still 115.0a1 but probably will bump up to 116.0a1 later today), and don't have the issues you mentioned. Will keep you updated once Firefox upgrades to 116.0a1.

@jiangzhenjerry that previous comment was deleted. After re-booting firefox DTA went back to normal. Never seen that happen before but everything with the program was doubled.