xiaoxiaoflood / firefox-scripts

userChromeJS / autoconfig.js and extensions
Mozilla Public License 2.0
989 stars 85 forks source link

Rehost Image login bug #66

Closed Sneakpeakcss closed 3 years ago

Sneakpeakcss commented 3 years ago

Hello @xiaoxiaoflood , i'm not exactly sure if this is intended behavior but looks more like a bug. After requesting PIN to imgur and signing in for the first time the extension recognizes the account and it creates an entry in firefox password manager with this data:

Web Site Address: chrome://rehostimage Username: {myimguraccoutname} Password: a string of "random" letter/numbers.

Imgur account settings says that the "Rehost Image" has access to the account.

And now the bug:

Rehost Image doesn't stay logged in/doesn't automatically upload to the previously added imgur account.

After signing in with PIN then closing the extension options window and opening it again, it doesn't recognize the account and asks for PIN once again. Trying to login with another PIN puts it into infinite loading with an error in console log: NS_ERROR_FAILURE: This login already exists. 2 LoginHelper.jsm:1312 Removing the entry from password manager allows it to login and recognize the account, but again only if the options menu isn't closed.

Extension technically uploads images to my account, but only if i manually login(and stay logged in) on imgur.com. It doesn't matter if the entry in password manager exists or if it's registered as an app in imgur settings:

Initially i thought it was because i'm using Waterfox Current, but i've tested it on Firefox ESR/Firefox Current and Firefox Developer Edition and the problem stays the same.

xiaoxiaoflood commented 3 years ago

Thanks for your report!

This should be fixed now, just update Rehost Image.