xiaoxiaoflood / firefox-scripts

userChromeJS / autoconfig.js and extensions
Mozilla Public License 2.0
989 stars 85 forks source link

Icons won't show in bookmark toolbar [Suggestion / Bug Fix] #77

Closed Sei-lus closed 3 years ago

Sei-lus commented 3 years ago

Suggestion / Bug Fix

When I put userChromeJS Manager and/or Extension Options Menu in the bookmark toolbar instead of the regular UICustomization toolbar their icon shows as a dot:

Screenshot 2021-04-14 152223

xiaoxiaoflood commented 3 years ago

I couldn't reproduce the issue. Moved EOM and ucJS Manager buttons to Bookmarks Toolbar and their icons are displayed normally, without a dot. Developer Edition 88.9b9.

Sei-lus commented 3 years ago

What do you recommend me to do to either fix it, or to replicate it in your machine?

xiaoxiaoflood commented 3 years ago

I can't do nothing unless you tell me steps to reproduce the issue. As I said, moving button to Bookmarks Toolbar is flawless here.

Sei-lus commented 3 years ago

@xiaoxiaoflood to be honest, I have no idea "how" to reproduce since I haven't done anything special. Installed the JS loader as per your instructions and the scripts themselves. I didn't install your whole extensive list of improvements, just a few because I didn't want to have too many things I don't use.

But I read your reply today, since you made an effort... I'll try to see what can I do to pinpoint the issue. In the next few days.

For now, what is special about my firefox browser?

One things that I do notice is this: image "Normal" addons switch to a different setup on the bookmark toolbar. Badge and stuff... It is a dynamic action, that apparently is not set on the icons for the js buttons. Sadly I don't have the ability to resolve this. Can you check if this might be something that you can relate to in your own browser? If you give me a no, I will make a new profile from scratch and see what is "conflicting" with the icons.

Either way, I don't care because it is just cosmetic. Love your repository and I'm thankful I came across it. Sincerely, A.

Edit: I'm sure you can read the code perfectly but I won't make assumptions that you have the will or time to do it because you know... this is a hobby of yours. Highlighted is one of the menu buttons that show as a "dot" in the bookmark toolbar. Undo Close Tab as an addon works fine which is below. Furthermore, I editted some typos.

xiaoxiaoflood commented 3 years ago

I just tested in a fresh new profile without any user setting. The only thing I did was install userChromeJS with rebuild_userChrome.uc.js and extensionOptionsMenu.uc.js. Both buttons display just fine when moved to Bookmarks Toolbar, either in light or dark theme.

You said you're using things to mod Fx interface. Given that it works for fine in my profile and also in a non-modded profile, it seems that the issue is not in my scripts but in your tweaks.

image

xiaoxiaoflood commented 3 years ago

Closing because I can't confirm the issue. If you get consistent steps to reproduce it, feel free to comment, then if I can reproduce it I'll reopen this.