search

xiaoyao-work / php-sql-parser

A pure PHP SQL (non validating) parser w/ focus on MySQL dialect of SQL
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Strict Standards warnings #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I am running PHP 5.5.7 with error_reporting = E_ALL.  When using 
php-sql-parser-20131130.zip, when I call "new PHPSQLParser($sql)" to parse a 
SQL query, I am getting the below warnings.  I was previously using 
php-sql-parser-20120822.zip, which didn't have these warnings.

Is it possible that these function declarations (and others like it) can be 
updated to avoid the strict standards warnings?  Thanks.

Strict Standards: Declaration of ReplaceProcessor::process() should be 
compatible with InsertProcessor::process($tokenList, $token_category = 
'INSERT') in /tmp/php-sql-parser/classes/processors/replace-processor.php on 
line 43

Strict Standards: Declaration of DuplicateProcessor::process() should be 
compatible with SetProcessor::process($tokens, $isUpdate = false) in 
/tmp/php-sql-parser/classes/processors/duplicate-processor.php on line 43

Strict Standards: Declaration of SelectProcessor::process() should be 
compatible with SelectExpressionProcessor::process($expression) in 
/tmp/php-sql-parser/classes/processors/select-processor.php on line 43

Strict Standards: Declaration of SQLProcessor::process() should be compatible 
with SQLExpressionProcessor::process($out) in 
/tmp/php-sql-parser/classes/processors/sql-processor.php on line 44

Original issue reported on code.google.com by ryan.bro...@gmail.com on 1 Jan 2014 at 6:25

GoogleCodeExporter commented 9 years ago 
Hm, this comes from class inheritance, I have changed the signature of some 
functions. Maybe I can use a parameter list instead of a fixed number of 
parameters.

Original comment by pho...@gmx.de on 6 Jan 2014 at 8:15

GoogleCodeExporter commented 9 years ago 
I have changed some functions in r902. Can you check that? With E_ALL | 
E_STRICT I don't get any further warnings (php 5.2).

Original comment by pho...@gmx.de on 6 Jan 2014 at 11:11

GoogleCodeExporter commented 9 years ago 
Thanks for your quick response.  I confirmed with your changes that the 
warnings aren't coming up anymore.

Original comment by ryan.bro...@gmail.com on 13 Jan 2014 at 3:11

GoogleCodeExporter commented 9 years ago

Original comment by pho...@gmx.de on 13 Jan 2014 at 8:11