search

xiaoyao-work / php-sql-parser

A pure PHP SQL (non validating) parser w/ focus on MySQL dialect of SQL
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Fix STRAIGHT_JOIN #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
STRAIGHT_JOIN is currently not handled properly. Parsing and creating SQL from 
the parse tree causes STRAIGHT_JOINs to become INNER JOINs which aren't quite 
the same.

The fixes were fairly simple, I've attached a patch which describes them (the 
formatting is a bit messed up unfortunately). It just creates a new join_type 
STRAIGHT_JOIN and causes STRAIGHT_JOIN to be evaluated the same as other JOINs.

Thanks for all your work on this project!

Original issue reported on code.google.com by noisecap...@gmail.com on 27 Mar 2014 at 4:02

Attachments:

GoogleCodeExporter commented 9 years ago 
The patch I added had a bug removing an extra line of code. I've attached an 
updated patch without that problem

Original comment by noisecap...@gmail.com on 28 Mar 2014 at 4:28

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry for the delay, I had a cold. I have added your patch in r1240, thank you 
very much!

Original comment by pho...@gmx.de on 31 Mar 2014 at 6:13