xiaoyao1991 / presto-ethereum

Presto Ethereum Connector -- SQL on Ethereum
Apache License 2.0
471 stars 56 forks source link

ERC-721 Table #31

Open xiaoyao1991 opened 6 years ago

yello123 commented 6 years ago

Can u put a description I would love to help on some of the issues.

xiaoyao1991 commented 6 years ago

@yello123 Thanks for the interest. Now since we are simply from parsing the Transfer events to populate erc20 table, some erc721 token transfers are mistakenly categorized as erc20 transfer. That's something we should fix as the first step.

In the long run, I'm thinking of making an ERC721 table that looks like ERC20. The problem with ERC721 is that the amount transferred is no longer part of the Transfer event. It was replaced by an id. We need to think of more use cases and design a good table schema.