Because of the typedef here and all its usages, code that uses SuperLU and also includes the complex.h header (that makes complex a reserved keyword) fails to compile.
Example issue: scipy/scipy#19036
If you agree to change this, I can start working on a PR. My understanding is that we'd have to do the following:
Patch any usages of complex in CBLAS and f2c-generated code. We've been doing this on numpy, so it shouldn't be too hard.
Change the typedef linked to above and all of its usages to something like singlecomplex.
lysnikolaou
commented
1 year ago
Because of the typedef here and all its usages, code that uses SuperLU and also includes the
complex.hheader (that makescomplexa reserved keyword) fails to compile.Example issue: scipy/scipy#19036
If you agree to change this, I can start working on a PR. My understanding is that we'd have to do the following:
complexin CBLAS andf2c-generated code. We've been doing this on numpy, so it shouldn't be too hard.typedeflinked to above and all of its usages to something likesinglecomplex.What do you think?