search

xiaoyeli / superlu

Supernodal sparse direct solver. https://portal.nersc.gov/project/sparse/superlu/
Other
281 stars 96 forks source link

exit(1) and fprintf in ILU #140

Closed LiuZhexuan closed 4 months ago

LiuZhexuan commented 8 months ago

In ilu_dpivotL, if singularity is detected, exit(1) will be triggered and cause the whole program be terminated. This is inconsistent with what happend in LU. In dpivotL, singularity will only cause LU return with some error info.

The way dpivotL do is more reasonable since superLU user may want to recover from singularity (e.g. add diagnoal matrix to original matix).

xiaoyeli commented 8 months ago

Fixed this behavior; not to exit(1).

gruenich commented 7 months ago

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

LiuZhexuan commented 7 months ago

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

Thanks, I pulled master branch and confirm this issue has been fixed. Please close.

gruenich commented 4 months ago

@xiaoyeli Please close this issue as Liu Zhexiuan confirmed it is fixed.