Open francesco-ballarin opened 3 months ago
The file is still in source, moved to SRC/single
by https://github.com/xiaoyeli/superlu_dist/commit/03c7adeb6c7035dd0b26c07cdd2eff7684cc6d63
The debian build compiles d_c2cpp_GetHWPM.cpp.o and z_c2cpp_GetHWPM.cpp.o, but no attempt is made to compile s_c2cpp_GetHWPM.cpp.o. Would this be a bug in the debian build configuration rather than a bug in superlu-dist?
I guess the culprit is https://github.com/xiaoyeli/superlu_dist/blob/ea4d47b206387a1592eea46493519d57cf3984d6/SRC/CMakeLists.txt#L271
which only adds s_c2cpp_GetHWPM.cpp
if enable_double
is not set (l.272). And enable_double
is set by default at https://github.com/xiaoyeli/superlu_dist/blob/ea4d47b206387a1592eea46493519d57cf3984d6/CMakeLists.txt#L23
Should the enable_single
block not have this enable_double
override at l.272 for HAVE_COMBBLAS
handling, and only be adding s_c2cpp_GetHWPM.cpp ? As done for enable_double
at https://github.com/xiaoyeli/superlu_dist/blob/ea4d47b206387a1592eea46493519d57cf3984d6/SRC/CMakeLists.txt#L194 and for enable_complex16
block at https://github.com/xiaoyeli/superlu_dist/blob/ea4d47b206387a1592eea46493519d57cf3984d6/SRC/CMakeLists.txt#L348
Or is there some other issue complicating single and double precision CombBLAS support?
Hi, we are trying to update superlu_dist to version 9.0 on Debian, with CombBLAS enabled.
The following cmake configuration is used when building the package locally:
We encounter two issues:
Can I ask you to double check if the logic at https://github.com/xiaoyeli/superlu_dist/blob/master/SRC/CMakeLists.txt#L274 is correct? We are in the case in which both
enable_double
andenable_single
are enabled, and the linker error seems to suggest that we would have needed to append bothdouble/d_c2cpp_GetHWPM.cpp
andsingle/s_c2cpp_GetHWPM.cpp
to the list.single/s_c2cpp_GetHWPM.cpp
anddouble/dHWPM_CombBLAS.hpp
to the list of sources inSRC/CMakeLists.txt
, I get a compilation error insingle/s_c2cpp_GetHWPM.cpp
, saying thatsHWPM_CombBLAS.hpp
is missing. Indeed, I can't find that file in thesingle
folder, but I can find a similardHWPM_CombBLAS.hpp
in thedouble
folder.Can you check whether
sHWPM_CombBLAS.hpp
should be added to the repository?cc @drew-parsons , since this issue is probably a follow up of https://github.com/xiaoyeli/superlu_dist/issues/110
Thanks, Francesco