Closed shenlebantongying closed 1 year ago
Of course we can use other things like
created_at
from the release api.
what about name
.
tag_**
generated by release action . I drop v
prefix to make it differentiate with the tags generated by the auto-tag action
I think for formal release, we should have just v23.07.23
as the tag which also includes built artifacts and is marked as release on GitHub.
Adding other things to it should be ok, but it should starts with v23.07.23-other_things
For places that rely on automated checkers, they can just grab it from github's release API and get the version number from the tag, or pick up releases via regex ^v[\.\d]+$
from all tags and do a simple sort to get the latest version.
https://github.com/xiaoyifang/goldendict-ng/issues/729#issuecomment-1571253078
https://github.com/xiaoyifang/goldendict-ng/issues/701#issuecomment-1550789220
Assuming this is fixed at the next release.
https://github.com/xiaoyifang/goldendict-ng/blob/f7e43479d6c3908a7cee759c9464dfffc2843092/src/ui/mainwindow.cc#L2905
From
v23.06.01-ChildrenDay.230601.6d3d4053
totag-GreatHeat.fbf82af1
This breaks things like
https://github.com/hu3rror/scoop-muggle/blob/276416923a11d63d99dfa1aa0229c601ef09eae5/bucket/goldendict-ng.json#L25-L30
https://salsa.debian.org/debian/goldendict-ng/-/blob/master/debian/watch#L4
that relies on v23.07.28.other_things :sweat_smile:
Of course we can use other things like
created_at
from the release api.