xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.64k stars 90 forks source link

Non correct filtered headwords number #1131

Closed GD-fix closed 3 weeks ago

GD-fix commented 1 year ago

Describe the bug Initially (i.e. with empty filter) in Dictionary headwords window there is non correct number (0) of filtered those (see the first and the second screenshots). After applying the non empty and then the empty again filter the number changes: for some dictionaries it is non correct (i.e. non equal to the Unique headwords total number) still (see the third screenshot: may be it's because of ignored due to the long size headwords?) and for other dictionaries it becomes correct (see the forth screenshot).

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Dictionaries panel'
  2. Click right on a dictionary
  3. Scroll down to the end of headwords list
  4. See error
  5. Print and then delete some letters in filter string
  6. Scroll down to the end of headwords list
  7. Compare

Expected behavior The equal numbers of Unique headwords total and filtered in case of empty filter.

Screenshots Screenshot_headwords_initial Screenshot_initial2 Screenshot_headwords_noncorrect Screenshot_headwords_correct

OS and software versions

GD-fix commented 1 year ago

P. S. ArchWiki doesn't have skipped during indexing headwords...

GD-fix commented 1 year ago

In current pre-release all the same...

GD-fix commented 11 months ago

In current pre-release all the same...

GD-fix commented 10 months ago

In current pre-release all the same...

And additional question: the fact that in ZIM dictionaries after applying the non empty and then the empty again filter the numbers of Unique headwords total and filtered aren't still equal is due to this (in case when abbreviated headwords are the same)?

GD-fix commented 10 months ago

In current release all the same...

xiaoyifang commented 10 months ago

I'll let you know when I finished this,

And I do not think this is a high priority issue.

GD-fix commented 9 months ago

Yes, of course, the impossibility of adding to GD-ng any dictionary at all is a much higher priority issue. But it also still not solved...

GD-fix commented 4 months ago

And what is the problem to correct the code, that it will be initially (on headwords window opening) the same as after filter applying?

GD-fix commented 3 weeks ago

The problem was solved.